KeeperFX work

[jomalin]

As you can see in that thread, on July 10th, 2012, there were 301 functions to be rewritten (that is searching for "return _DK_" WITHOUT including C comments like "//return _DK_").
Now on r696, we are on 284.

Good work mefisto! :-)

[jomalin]

Just to keep tracking of KeeperFX development process...

On the latest KeeperFX SVN version (r704), we have 312 functions to be rewritten, more than in r696 that were 284. How is this possible that we have now more?

Finally, I get the regular expression (regex) I was trying to. It is for Notepad++, using the option "Search in Files...", checking the radiobutton "Regular expression" (it uses Scintilla regular expression engine) and selecting where the KeeperFX source code files are. That's it:
^\s*return\s+_DK_

This finds: any line that starts with 0 or more spaces + "return" + 1 or more spaces + "_DK_"

[mefistotelis]

On the latest KeeperFX SVN version (r704), we have 312 functions to be rewritten, more than in r696 that were 284. How is this possible that we have now more?

I did added a few definitions, but it was ~10, and not 30. I don't know.

[jomalin]

Sorry mefistotelis, I did a mistake (because I did the search manually in my counts...)!

This is the process I use to get the count (2 steps). Basically, download the source files using the svn command, and doing a specific regex search in Notepad++:

1. I download files from repository using that command line:
svn checkout http://keeperfx.googlecode.com/svn/t...eperfx/[email protected]

Where "XXX" is the revision number from the SVN. For example, to download the source files from r696 I execute:
svn checkout http://keeperfx.googlecode.com/svn/t...eperfx/[email protected]

I execute that always from his corresponding folder (C:\keeperfxr696, C:\keeperfxr704, C:\keeperfxr706, etc), so I download each version to a different folder.

2. Then, in Notepad++, I execute "Find in files" through all the source code files from the corresponding folder, checking "Regular expression" radiobutton, using these two regular expressions

This search lines starting with any number of spaces (0 or more) + "return" + 1 or more spaces + "_DK_":
^\s*return\s+_DK_

This search lines starting with any number of spaces (0 or more), and then "_DK_"
^\s*_DK_

So here are the final GOOD results.

FUNCTIONS TO BE REWRITTEN

-------------------|return _DK_|_DK_|
KeeperFX 0.40--|----392------|-------|
KeeperFX 0.41--|----321------|-------|
KeeperFX r696--|----317------|-------|
KeeperFX r704--|----312------|-------|
KeeperFX r706--|----312------|-------|
KeeperFX r707--|----311------|-------|
KeeperFX r711--|----310------|-------|
KeeperFX r718--|----309------|--351-|
KeeperFX r719--|----309------|--350-|
KeeperFX r720--|----309------|--349-|
KeeperFX r721--|----322------|--349-|
KeeperFX r735--|----303------|--351-|
KeeperFX r737--|----303------|--346-|
KeeperFX 0.42--|----297------|--346-|
KeeperFX r745--|----294------|--347-|
KeeperFX r753--|----292------|--347-|
KeeperFX r762--|----290------|--351-|
KeeperFX r766--|----285------|--351-|
KeeperFX r769--|----285------|--348-|
KeeperFX r772--|----284------|--347-|
KeeperFX r779--|----281------|--347-|
KeeperFX r782--|----279------|--348-|
KeeperFX r785--|----278------|--348-|
KeeperFX r787--|----278------|--338-|
KeeperFX r791--|----276------|--338-|
KeeperFX r804--|----273------|--336-|
KeeperFX r809--|----272------|--332-|
KeeperFX r811--|----270------|--332-|
KeeperFX r813--|----270------|--332-|
KeeperFX r816--|----267------|--332-|
KeeperFX r820--|----264------|--332-|
KeeperFX r824--|----267------|--332-|
KeeperFX r836--|----265------|--338-|
KeeperFX r842--|----261------|--338-|
KeeperFX r847--|----255------|--338-|
KeeperFX r858--|----248------|--336-|
KeeperFX r869--|----247------|--335-|
KeeperFX r872--|----245------|--334-|
KeeperFX r878--|----244------|--333-|
KeeperFX r887--|----241------|--330-|
KeeperFX r899--|----228------|--330-|
KeeperFX r900--|----229------|--330-|
KeeperFX r911--|----228------|--330-|
KeeperFX r945--|----218------|--328-|
KeeperFX r954--|----213------|--323-|
KeeperFX r964--|----213------|--322-|
KeeperFX r975--|----211------|--321-|
KeeperFX r983--|----211------|--318-|
KeeperFX r989--|----210------|--317-|
KeeperFX r1084-|----193------|--319-|
KeeperFX r1110-|----187------|--306-|
KeeperFX r1116-|----186------|--287-|
KeeperFX r1121-|----184------|--287-|
KeeperFX r1135-|----180------|--287-|
KeeperFX r1167-|----178------|--286-|
KeeperFX r1191-|----173------|--285-|
KeeperFX r1191-|----173------|--285-|
KeeperFX r1197-|----169------|--284-|
KeeperFX r1198-|----169------|--217-|
KeeperFX r1200-|----168------|--213-|
KeeperFX r1202-|----168------|--202-|
KeeperFX r1203-|----168------|--192-|
KeeperFX r1205-|----168------|--188-|
KeeperFX r1207-|----168------|--187-|
KeeperFX 0.4.5--|----168------|--185-|
KeeperFX r1224-|----167------|--182-|
KeeperFX r1228-|----165------|--182-|
KeeperFX r1233-|----164------|--182-|
KeeperFX r1238-|----163------|--177-|
KeeperFX r1244-|----163------|--173-|
KeeperFX r1247-|----163------|--158-|
KeeperFX r1258-|----161------|--152-|
KeeperFX r1276-|----161------|--151-|
KeeperFX r1283-|----161------|--151-|
KeeperFX r1292-|----161------|--151-|
KeeperFX r1309-|----161------|--151-|
KeeperFX r1318-|----161------|--148-|
KeeperFX r1325-|----161------|--148-|
KeeperFX r1331-|----157------|--147-|
KeeperFX r1356-|----149------|--143-|
KeeperFX r1410-|----148------|--137-|
KeeperFX r1415-|----147------|--134-|
KeeperFX r1422-|----143------|--134-|
KeeperFX r1428-|----142------|--132-|
KeeperFX r1446-|----143------|--127-|
KeeperFX r1460-|----139------|--124-|
KeeperFX r1467-|----139------|--117-|
KeeperFX r1482-|----135------|--114-|
KeeperFX r1493-|----135------|--106-|
KeeperFX r1503-|----135------|--105-|
KeeperFX r1510-|----134------|--105-|
KeeperFX r1520-|----133------|--102-|
KeeperFX r1522-|----132------|--101-|
KeeperFX r1524-|----132------|--100-|
KeeperFX r1536-|----133------|--99--|
KeeperFX r1540-|----133------|--95--|
KeeperFX r1573-|----128------|--83--|
KeeperFX r1580-|----127------|--83--|
KeeperFX r1589-|----112------|--83--|
KeeperFX r1594-|----106------|--80--|
KeeperFX r1560-|----105------|--79--|
KeeperFX r1648-|----104------|--79--|
KeeperFX r1679-|-----92------|--62--|
KeeperFX r1706-|-----92------|--62--|
KeeperFX r1751-|-----90------|--60--|
KeeperFX r1813-|-----86------|--58--|
KeeperFX r1850-|-----84------|--55--|

mefistotelis, now it seems OK to you?

[jomalin]

Updated information:

FUNCTIONS TO BE REWRITTEN

---------------------------|return _DK_|_DK_ |
KeeperFX r3033-|-------21--------|--26--|

[Necror]

Updated information:

FUNCTIONS TO BE REWRITTEN

---------------------------|return _DK_|_DK_ |
KeeperFX r3033-|-------21--------|--26--|

you can find a list of functions that still need rewriting here
https://docs.google.com/spreadsheets...it?usp=sharing

most of them already have a PR, but still have bugs in them that need figuring out before they can be merged

oh and also just doing that regex won't show functions that are only called by functions still in the dll, so the old numbers were a bit low, by now all that remains is only 1 lvl deep, or only calls already rewritten stuff
not that many functions were rewritten between when mefisto left (2015) and I picked up rewriting again(2022) but I believe about 100 functions were rewritten in 2022 and still 22 to go